Impress: Make master slides import from templates folder available for use in the sidebar

[Rash419]

Is your feature request related to a problem? Please describe.
Import templates from nextcloud in "master slides" of Collabora Online's impress, similar to remote fonts

Describe the solution you'd like

• We are adding a new remote_asset_config.url config in COOL with PR Improve impress templates CollaboraOnline/online#10463. This will work similarly to remote_font_config

• This will be upgrade a from remote_font_config.url which was only designed for fonts but remote_asset_config can take fonts, templates and can also be extended in the future if we want fetch other kind of assets.

• from the richdocuments' side I expect a new endpoint which can serve json which can have both fonts and impress presentation templates.

• json format would be

{
  "kind": "assetconfiguration",
  "server": "remoteserver",
  "templates": {
    "presentation": [
      {
        "uri": "http://localhost:8080/static/impress-template/template1.otp",
        "version": "1"
      },
      {
        "uri": "http://localhost:8080/static/impress-template/template2.otp",
        "version": "2"
      },
      {
        "uri": "http://localhost:8080/static/impress-template/template3.otp",
        "version": "3"
      }
    ]
  },
  "fonts": [
    {
      "uri": "http://localhost:8080/static/font/font1.ttf",
      "version": "1"
    },
    {
      "uri": "http://localhost:8080/static/font/font2.ttf",
      "version": "2"
    },
    {
      "uri": "http://localhost:8080/static/font/font3.ttf",
      "version": "3"
    }
  ]
}

Additional context

• For backward compatibility we have kept remote_font_config.
• I have created RemoteConfigServer for testing

[juliusknorr]

Very nice proposal. Some quick feedback/questions:

• stamp is quite unintuitive naming imo, maybe call it version or etag or mtime which are more common names from my perspective
• It would just be regular odp files where the master slides are used then? Would otp files also be supported? How about pptx?

[juliusknorr]

• Implementing the endpoint should be straight forward based on the font list endpoint

  richdocuments/lib/Service/FontService.php

  Lines 97 to 113 in 9ca8814

  	public function getFontList(array $fontFiles): array {
  	$url = $this->url;
  	$list = array_map(
  	static fn (ISimpleFile $f) => [
  	'uri' => $url->linkToRouteAbsolute(Application::APPNAME . '.settings.getFontFile', ['name' => $f->getName()]),
  	'stamp' => $f->getETag(),
  	],
  	$fontFiles
  	);
  	$instanceName = $this->config->getAppValue('theming', 'name');
  	return [
  	'kind' => 'fontconfiguration',
  	'server' => $instanceName . ' (' . $this->url->getBaseUrl() . ')',
  	'fonts' => $list,
  	];
  	}

• As collabora only has one global list of templates and not individual ones per user joining a document, we can only use admin provided templates here
  • As a start we can pull the templates form the richdocuments system template directory
  • We can think about shipping our templates from the example files by default in richdocuments
  • Optional: Otherwise we'd need a improved admin provided template mechanism File template rework server#46455

[juliusknorr]

@Rash419

"presnt"

is that a typo or any reason to not have "presentation" or something like that?

[Rash419]

@Rash419

"presnt"

is that a typo or any reason to not have "presentation" or something like that?

@juliusknorr Not a typo but we can use "presentation" or "impress" I guess

[Rash419]

Very nice proposal. Some quick feedback/questions:

Thanks

* stamp is quite unintuitive naming imo, maybe call it version or etag or mtime which are more common names from my perspective

sure. I can update it to use "version" .

* It would just be regular odp files where the master slides are used then? Would otp files also be supported? How about pptx?

I have tested only with "otp" files as of now because they are the template files for impress. I will check and get back to you : )

[Rash419]

• stamp is quite unintuitive naming imo, maybe call it version or etag or mtime which are more common names from my perspective

Updated the JSON to use version

• It would just be regular odp files where the master slides are used then? Would otp files also be supported? How about pptx?

OTP and ODP files are supported. PPTX is not supported

is that a typo or any reason to not have "presentation" or something like that?

Updated, we use "presentation" now : )

[juliusknorr]

One follow up question, would it be fine for the version to be an alphanumeric string like an etag (e.g. 674dd5fddf389), that would be an actual identifier within Nextcloud that we can be sure to be updated once the file changes.

[Rash419]

Yes, it can be any string 🙂

…

On Mon, 2 Dec, 2024, 9:41 pm Julius Knorr, ***@***.***> wrote: One follow up question, would it be fine for the version to be an alphanumeric string like an etag (e.g. 674dd5fddf389), that would be an actual identifier within Nextcloud that we can be sure to be updated once the file changes. — Reply to this email directly, view it on GitHub <#4276 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIGQLPUVM2V2OJRNB4Z4QT2DSBEZAVCNFSM6AAAAABSUSQBFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJRHE3TQNBTGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[juliusknorr]

Great, did a first implementation at #4300, with some todo left but will try to finish the next days

[juliusknorr]

One additional idea, we could actually consider exposing this endpoint as a .well-known url on the Nextcloud side. I wonder if we could make it easier for admins then if collabora could auto-discover the endpoint based on just an allowed wopi host.