Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): add title for files list table header button #48898

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 25, 2024

In some languages 2 * --height is not enough to fit some table header button texts. Adding title.

I'm not a fun of having title all the time, but I don't see a simple alternative.

Screenshots

🏚️ Before 🏑 After
image image

Checklist

@ShGKme ShGKme added this to the Nextcloud 31 milestone Oct 25, 2024
@ShGKme ShGKme requested review from susnux and Pytal October 25, 2024 16:18
@ShGKme ShGKme self-assigned this Oct 25, 2024
@ShGKme ShGKme requested a review from skjnldsv as a code owner October 25, 2024 16:18
@nickvergessen nickvergessen merged commit 7b36547 into master Oct 25, 2024
118 checks passed
@nickvergessen nickvergessen deleted the fix/files--list-header-button-title branch October 25, 2024 20:50
@nickvergessen
Copy link
Member

/backport f7498d0 to stable30

@nickvergessen
Copy link
Member

/backport f7498d0 to stable29

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 26, 2024

/backport f7498d0 to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants