Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend for "Recognize email guests" #13606

Closed
12 of 21 tasks
nickvergessen opened this issue Oct 22, 2024 · 7 comments
Closed
12 of 21 tasks

Frontend for "Recognize email guests" #13606

nickvergessen opened this issue Oct 22, 2024 · 7 comments

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Oct 22, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.


🖌 Frontend

  • We don't want to distinguish between guests and email-guests anymore in the UI
    • Show account icon for both moderators and users (👤, no questionmark anymore, should be the same as for former-one-to-one)
    • Show first letter when a custom name is set
    • Only show email icon for moderators when searching / adding a new participant (invite e-mail)
    • Show always (guest) badge
    • Show always on grey background
    • Show the invited email address to moderators in the participants list
    • Check "Guest (Guest)" intermediate name ? (Web - do not pass default "Guest" or "Deleted user" to AvatarWrapper)
  • Resending the invite shows the ID instead of the name
  • Guest name dialog
    • Show the invited email address on the "Guest name screen"
    • Should we hide the "have an account, login here?" message from that screen?
  • Other places:
    • Check mentions (note their guest ID is longer than the old guests actor id and therefore potentially the regex needs adjusting)
    • Mail address should be shown in auto-complete, but not in mention-chips
    • Check autocomplete
    • Check call view
    • The mail address is shown for moderators in the callview and message sender (like it's done for federated users)
    • Mention and sender is missing from API -> Needs to be clarifies by Joas if it's possible

@nickvergessen nickvergessen added this to the 🌠 Next Minor (30) milestone Oct 22, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Oct 22, 2024
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 💬 Talk team Oct 22, 2024
@SystemKeeper
Copy link
Contributor

  1. Currently for an email invite it shows "Guest (Guest)" in the participant list:

    Should the email be shown there? Only for moderators? (Property invitedActorId).

  2. Show ? when "default Guest" name is used (?)
    Since we enforce a guest name nowadays, this will never be the case?

@nickvergessen
Copy link
Member Author

That's exactly what the ticket is about 😅

@SystemKeeper
Copy link
Contributor

That's exactly what the ticket is about 😅

I don't see any of my questions addressed in this initial post 😅

@SystemKeeper
Copy link
Contributor

SystemKeeper commented Oct 22, 2024

Resending the invite shows the ID instead of the name:

There seems to be a race condition somewhere in the frontend, when trying to resend the invitation in the wrong moment, it's send to another participant (might be a general problem with the menu we had in the past?)

@nickvergessen
Copy link
Member Author

I don't see any of my questions addressed in this initial post 😅

Right, I had only talked about those with Ivan and Maksim at the office. Anyway, edited the first post.

@Antreesy
Copy link
Contributor

Antreesy commented Nov 7, 2024

Noticed while testing
image

@nickvergessen
Copy link
Member Author

@Antreesy All done by now, so we can close?

@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 💬 Talk team Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

No branches or pull requests

3 participants