Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(media): checking for config existence, not value #13970

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(media): checking for config existence, not value #13970

merged 1 commit into from
Dec 10, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 10, 2024 •
edited by nickvergessen
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Dec 10, 2024
@Antreesy Antreesy requested a review from DorraJaouad December 10, 2024 11:58
@Antreesy Antreesy self-assigned this Dec 10, 2024
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit e9e20f9 into main Dec 10, 2024
47 checks passed
@Antreesy Antreesy deleted the fix/13952/start-no-media-fixup branch December 10, 2024 13:33
@backportbot backportbot bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @miaulalala