Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use union types in unit tests #8677

Closed
nickvergessen opened this issue Feb 3, 2023 · 1 comment
Closed

Use union types in unit tests #8677

nickvergessen opened this issue Feb 3, 2023 · 1 comment
Labels
1. to develop feature: api 🛠️ OCS API for conversations, chats and participants technical debt
Milestone
💔 Backlog

Comments

@nickvergessen
Copy link
Member

Union types works native since PHP 8.0.

https://www.php.net/manual/en/language.types.declarations.php
https://3v4l.org/ArLAg

	private INotificationManager|MockObject $notificationManager;

Maybe we can follow changing the code that we touch removing the union type from annotation and use the native way.

Originally posted by @vitormattos in #8672 (comment)
@nickvergessen nickvergessen added 1. to develop feature: api 🛠️ OCS API for conversations, chats and participants technical debt labels Feb 3, 2023
@nickvergessen nickvergessen added this to the 💔 Backlog milestone Feb 3, 2023
@nickvergessen nickvergessen mentioned this issue Feb 3, 2023
Merged
4 tasks
@nickvergessen
Copy link
Member Author

Done with #12074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop feature: api 🛠️ OCS API for conversations, chats and participants technical debt
Projects
None yet
Milestone
💔 Backlog
Development

No branches or pull requests
1 participant
@nickvergessen