Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve job-status query logic and nf-tower support #77

Closed
abhi18av opened this issue Aug 9, 2024 · 5 comments · Fixed by #91
Closed

Improve job-status query logic and nf-tower support #77

abhi18av opened this issue Aug 9, 2024 · 5 comments · Fixed by #91
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@abhi18av
Copy link
Member

abhi18av commented Aug 9, 2024

The job query status logic needs to be revamped in order to work well with Tower.

As of now, the jobs (on Tower) are always shown as running and are not progressing to completed status. Despite being actually completed on the cluster itself.

image

Also, as a result, the pipeline execution report (within nf-core pipelines) also doesn't contain any relevant information.

image
@abhi18av abhi18av changed the title Improve jub-status query logic Improve job-status query logic Aug 9, 2024
@abhi18av abhi18av self-assigned this Aug 9, 2024
@abhi18av abhi18av changed the title Improve job-status query logic Improve job-status query logic and nf-tower support Aug 9, 2024
@abhi18av abhi18av added the enhancement New feature or request label Aug 12, 2024
@abhi18av
Copy link
Member Author

abhi18av commented Sep 18, 2024

@jagedn , now that our NomadService class has been refactored via #89 , maybe we should pick this up again?

@jagedn
Copy link
Collaborator

jagedn commented Oct 19, 2024

One question:

I've tried to run a simple pipeline using local executor + tower

nextflow-io/rnaseq-nf --proces.executor=local

and I can see it is created in tower, but the status of the tasks are not updated and the spinner is always running. If I refresh the page them all looks fine

Is this a typical use case of Tower or I'm doing something wrong and Tower is able to show in runtime, without any refresh, the situation of the tasks ?

`

@jagedn
Copy link
Collaborator

jagedn commented Oct 20, 2024

So, I'm working in a revamp of the status logic and now I can see information in tower running ./run-pipeline.sh -c tower/nextflow.config nf-core/fetchngs -profile test -with-tower --outdir $(pwd)/nomad_temp/scratchdir/out

but Tower doesn't refresh the status of the tasks, I need to refresh the page. Not sure if this is an issue of Tower

Running this pipeline and once the pipeline completed I can see :

imagen

imagen

imagen

imagen

imagen

so from my side it seems is working except tower doesnt refresn in realtime the information (also I was debugging and I was able to see the plugin is sending the info to the remote server during the execution of the pipeline)

@abhi18av
Copy link
Member Author

abhi18av commented Oct 21, 2024

so from my side it seems is working except tower doesnt refresn in realtime the information (also I was debugging and I was able to see the plugin is sending the info to the remote server during the execution of the pipeline)

This is great Jorge - and welcome back 😉

The Tower page generally should refresh automatically, but the best experience is when the pipeline is launched through Tower itself. In the monitoring use-case, afaict, there is a bit of time lag before updates.

I think this can conclude the current iteration and we can make the release for v0.3.1.

Let's create a PR and I can also test locally for this.

@abhi18av abhi18av added this to the v0.3.1 milestone Oct 21, 2024
@jagedn
Copy link
Collaborator

jagedn commented Oct 21, 2024

Still working on it (tests are failing) but you can grab this branch and test in your local

https://github.com/nextflow-io/nf-nomad/tree/tower-nf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants