Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DestinationSetFilter-name is not consistent with the Generated Script #6173

Open
Yostheboss opened this issue Apr 18, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@Yostheboss
Copy link

Describe the bug
When a Destination Set Filter is created on a channel, and multiple values are added with the Condition 'Not Equal', I see that the Name of the filter shows that it's an OR filter, but the generated script shows && in the scripts. That is not consistent with the name...
When I change the condition from 'not equal' to 'equals', the generated script shows || so that's fine.

Expected behavior
I should expect consitency between the name of the filter and the generated script. When it uses '&&' the name should describe it as an 'AND' filter. When the script generates || the name should describe an OR filter.

Actual behavior
When I create a filter with multiple values, the name says 'OR', but the generated script is an AND filter. (only when "Does not equal" is selected)

Screenshots

filter
generated_script

Environment (please complete the following information):

  • Windows server 2019
  • Java version: 17.0.6
  • Connect Version 4.4.1

Additional context
Add any other context about the problem here.

@Yostheboss Yostheboss added the bug Something isn't working label Apr 18, 2024
@tonygermano
Copy link
Collaborator

I think the wording is ok. That's typically how you would say it when spoken. Logically !(a || b || c) is equivalent to !a && !b && !c. If the wording were to be changed to use an "and" it should say does not equal 'abc' and does not equal 'def', which is pretty verbose, especially if there are more than two things to list.

If anything, I would change the wording to in list or not in list when there is more than 1 value being compared for "equals" or "not equals" and get rid of the logical expressions in the description altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants