Noisify genebank transform #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...about violated expectations around `database` and `location` fields in the input record. Note: I choose to have the `parse_location` method bail early and return an unmodified record if the `location` field isn't found. The other alternative is to issue the warning but add the empty `country`, `division`, and `location` records. I don't have strong feelings about this one way or the other; if somebody does, I'll change this behavior.
joverlee521
approved these changes
May 20, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds expectation checks to
transform-genbank-librarythat issue warnings when the input record does not have the expected shape. Also adds tests for both the default transformation behavior and the new warnings.Related issue(s)
#35
Checklist