Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

username isn't found for a fid route #24

Open
MrKevinOConnell opened this issue Jul 16, 2024 · 1 comment
Open

username isn't found for a fid route #24

MrKevinOConnell opened this issue Jul 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@MrKevinOConnell
Copy link
Collaborator

MrKevinOConnell commented Jul 16, 2024

original cast: https://warpcast.com/behkod.eth/0x249d7695

Neynar explorer under "Example FID" is redirecting to wrong user. Its treating FID as a username. [Dan's FID is going to user @\3]

Steps to reproduce:
1.) - Go to e.g. explorer.neynar.com/3 [link below]

hints to solve:
1.) go to /src/app/[identifier]
2.) this line is incorrect for both supercast and warpcast:

                    authorFidCast
                      ? `https://www.supercast.xyz/c/${castHash}`
                      : `https://www.supercast.xyz/${username}`
                  }
  • figure out why username isn't being retrieved for a fid
const username =
    warpcast?.author?.username ??
    neynar?.author?.author?.username ??
    neynar?.cast?.cast?.author?.username ??
    warpcast?.cast?.author?.username ??
    null;
@MrKevinOConnell MrKevinOConnell added the bug Something isn't working label Jul 16, 2024
@behkod
Copy link

behkod commented Jul 16, 2024

Hey @MrKevinOConnell ,

Thanks for creating the issue.

But unfortunately it's not just this.

AFAICT there's a problem w/ the search as follows:

When you search for an FID that there's a corresponding username for it, The Warpcast API, Hoyt & Neynar Hub are giving it (search token as a username) a higher precedence over the token as an FID. And only the Neynar API works as presumed (Searching only on FID fields).

For example: If you're searching for 3 in the search field, those three will return data related to the "fid": 1754 & not dwr.eth, thus the pop-ups for those three under renderHeader will show data for fid=1754 [as follow:]
neynex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants