Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty path components from output paths #372

Closed
wants to merge 1 commit into from

Conversation

siddharthab
Copy link

@siddharthab siddharthab commented Jul 4, 2024

GCS does not allow double slashes (//) in paths by default. Other cloud storage platforms also do not have a well-defined behavior for them.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/atacseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

GCS does not allow double slashes (`//`) in paths by default. Other
cloud storage platforms also do not have a well-defined behavior for
them.
Copy link

github-actions bot commented Jul 4, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @siddharthab,

It looks like this pull-request is has been made against the siddharthab/atacseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the siddharthab/atacseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@siddharthab siddharthab changed the base branch from master to dev July 4, 2024 16:23
@siddharthab
Copy link
Author

Looks like this was fixed by #355.

@siddharthab siddharthab closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant