Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computemarix tssfix 193 #228

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Computemarix tssfix 193 #228

merged 1 commit into from
Nov 22, 2022

Conversation

robsyme
Copy link
Contributor

@robsyme robsyme commented Nov 21, 2022

TSS heatmap inconsistency Fix

Fixes for the Deeptools matrix computation which flows to heatmap generation, fixing issue #193.

Previously, we were passing the gene bed file, when we should have been passing the tss bed file. The TSS bed file as it is currently generated produces a list of regions 1bp wide, specifying just the TSS start site. These regions are too small for the deeptools computeMatrix step to handle. By default, the minimum bin width is 10bp and regions smaller than this are discarded by deeptools. This PR also includes an awk snippet that expands any regions smaller than 10bp in the bed file to meet the 10bp window size minimum.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/atacseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@robsyme
Copy link
Contributor Author

robsyme commented Nov 21, 2022

This is not yet ready for review, apologies.

@robsyme robsyme force-pushed the computemarix-tssfix-193 branch from dc8eeeb to aea3caf Compare November 22, 2022 04:50
@robsyme
Copy link
Contributor Author

robsyme commented Nov 22, 2022

I've rebased and squashed my initial attempt at this fix as there was a very simple fix available.

We produce two plots using deeptools - the profile plot over the whole transcript using computeMatrix scale-regions tool
image

... and the plot over just the TSS and surrounding 3kb using the computeMatrix reference-point tool (figure truncated for brevity):
image

We can re-use the existing nf-core module without modification (huge thanks to the original authors for envisaging this predicament) changing only module configuration with ext.args. Other tools remain

@robsyme
Copy link
Contributor Author

robsyme commented Nov 22, 2022

The argument could be made that the "genes" label (taken from the bed file name) is not particularly informative, but it appears that plotHeatmap does not provide an option to remove those labels in the profiler tool.

@robsyme robsyme requested a review from drpatelh November 22, 2022 05:18
@drpatelh
Copy link
Member

Great thanks @robsyme !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants