Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add germlinecnvcaller #10

Merged
merged 32 commits into from
Sep 11, 2023
Merged

Add germlinecnvcaller #10

merged 32 commits into from
Sep 11, 2023

Conversation

ramprasadn
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/createpanelrefs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ramprasadn ramprasadn marked this pull request as ready for review September 11, 2023 15:49
main.nf Show resolved Hide resolved
ch_versions = ch_versions.mix(GATK4_GERMLINECNVCALLER.out.versions.first())

emit:
versions = ch_versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should emit the output from GATK4_GERMLINECNVCALLER as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really be using the output anywhere else that's why I didn't add it here.. Don't mind doing it, but I am curious to know your reason. Is it just good practice? Or there are other reason we should do it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say good practice (plus some other ideas I'm trying to work in)
I need to check I'm actually doing that in the other subworkflows...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I will add it 👍🏻

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I'm almost considering pushing your subworkflows to nf-core/modules

@ramprasadn
Copy link
Contributor Author

ramprasadn commented Sep 11, 2023

I don't think this cohort mode analysis will find use in other pipelines, since its something an user will run occasionally to create references.. In that case, its probably easier to use this pipeline to create those files.. But this workflow calling cnvs in case mode could be of use to others.. I can polish that one a bit and add it to modules.

@ramprasadn ramprasadn merged commit 315c0fb into nf-core:dev Sep 11, 2023
9 checks passed
@ramprasadn ramprasadn deleted the gcnvcaller branch September 11, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants