Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests work again on release PR upon fixes in modules / utils subworkflows #243

Open
apeltzer opened this issue Aug 13, 2024 · 4 comments
Open

Make tests work again on release PR upon fixes in modules / utils subworkflows #243

apeltzer opened this issue Aug 13, 2024 · 4 comments
Milestone
1.6.0

Comments

@apeltzer
Copy link
Member

apeltzer commented Aug 13, 2024 •
edited
Loading

Unfortunately the tests don't work anymore. I suspect that it has to do something with this one here: nf-core/test-datasets#1283
@apeltzer apeltzer added this to the 1.5.0 milestone Aug 13, 2024
@nschcolnicov
Copy link
Contributor

On it

@atrigila
Copy link
Contributor

I think that in the PR the compressed 220422_M11111_0222_000000000-K9H97.tar.gz was also removed and it is used in several samplesheets. I am going to inspect and see if we can revert the commit.

@atrigila
Copy link
Contributor

The tests related to the pipeline are working now. The failing tests are related to the utils_* subworkflows and nf-validation plug-ins. We are working on this.

@apeltzer apeltzer modified the milestones: 1.5.0, 1.6.0 Aug 13, 2024
@apeltzer apeltzer changed the title Make tests work again on release PR Make tests work again on release PR upon fixes in modules / utils subworkflows Aug 13, 2024
@apeltzer
Copy link
Member Author

Related PRs nf-core/tools#3111
and nf-core/modules#6166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@apeltzer @atrigila @nschcolnicov