Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sample-level merged BAMs for sample-level statistics #1065

Closed
TCLamnidis opened this issue Apr 26, 2024 · 1 comment
Closed

Use Sample-level merged BAMs for sample-level statistics #1065

TCLamnidis opened this issue Apr 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working DSL2
Milestone

Comments

@TCLamnidis
Copy link
Collaborator

Qualimap needs an ext.prefix.

Additionally, Qualimap results are meant to be at the sample level, but are currently at the Library level. We need to use post-Library-merge BAMs as input for this module.

The additional complication is that MERGE_LIBRARIES currently runs on the BAMs specified by genotyping_source, but other modules probably should run on the raw ones. Maybe always merge the raw ones and only merge trimmed/pmd/rescaled when asked? Then the raw merged sample-level bams can go to Qualimap.

This might also apply to BEDTOOLS_COVERAGE, though I am not entirely sure. @aidaanva ?

@TCLamnidis TCLamnidis added bug Something isn't working DSL2 labels Apr 26, 2024
@TCLamnidis TCLamnidis added this to the 3.0 Augsburg milestone Apr 26, 2024
@aidaanva
Copy link
Contributor

Yes, BEDTOOLS_COVERAGE should run on raw merged ones since the user may want to run those with mapping quality 0, which will not be appropriate for genotyping.

@scarlhoff scarlhoff self-assigned this Jul 26, 2024
@scarlhoff scarlhoff mentioned this issue Jul 29, 2024
11 tasks
@scarlhoff scarlhoff linked a pull request Jul 29, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DSL2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants