-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange quant and prepare for release 2.5.0 #280
Conversation
|
Sorry that the PR is so huge.. the metadata was not properly processed through the rarely used subworkflows predict_class1 and predict_class2, therefore I needed to adjust these as well. I added test, still need to wait for publicly availabe bruker data to add those tests. Will need to merge the template update as well I guess.. |
Template merged ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, LGTM
Changes:
-> Merged percolator files are now split again into runs, filtered, aligned, quantified.
-> With this we quantify the same peptide we obtain during Identification (core)
Before:
After:
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).