Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gstring interpolation in getFileExtension #151

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

LouisLeNezet
Copy link
Collaborator

Fix GString error

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet requested a review from hemanoel October 30, 2024 10:27
@LouisLeNezet LouisLeNezet self-assigned this Oct 30, 2024
@LouisLeNezet LouisLeNezet added the bug Something isn't working label Oct 30, 2024
@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Oct 30, 2024
@LouisLeNezet LouisLeNezet linked an issue Oct 30, 2024 that may be closed by this pull request
@LouisLeNezet LouisLeNezet changed the title Fulltest Fix Gstring interpolation in getFileExtension Oct 30, 2024
@hemanoel
Copy link
Contributor

It worked fine until glimpse1 (it might be an internet issue to download the docker image)

@LouisLeNezet LouisLeNezet merged commit 10985a2 into nf-core:dev Oct 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Type not supported: class org.codehaus.groovy.runtime.GStringImpl
2 participants