Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter for using the --save_reference 'genome' directory #998

Open
kaboroevich opened this issue Apr 11, 2023 · 3 comments
Open

Parameter for using the --save_reference 'genome' directory #998

kaboroevich opened this issue Apr 11, 2023 · 3 comments

Comments

@kaboroevich
Copy link

Description of feature

Using the --save_reference parameter retains all the intermediate reference files in the <RESULTS_DIR>/genome directory. However, from my understanding of the parameters documentation, for subsequent runs of the pipeline, each of the reference parameters (--fasta, --gtf, --star_index, --salmon_index, etc.) have to be defined individually. It would be helpful if the path to the genome folder could be provided to a single parameter, such as --use_saved_reference, from which the pipeline would extract the relevant paths.

@drpatelh drpatelh added this to the 3.12 milestone May 7, 2023
@drpatelh
Copy link
Member

drpatelh commented May 30, 2023

Hi @kaboroevich ! This is a good suggestion and something I have been thinking about to make it easier to re-use the references saved when using --save_reference. The idea with --save_reference has always been to move the genome folder somewhere else for re-use rather than being stored in the results folder for a single experiment. I will see if we can improve this behavior in later releases.

@drpatelh drpatelh modified the milestones: 3.12, 3.13 May 30, 2023
@amizeranschi
Copy link

Hi @drpatelh

I tried using the --save_reference option now in nf-core/rnaseq and I noticed that the salmon reference isn't saved in the genome/index/ directory, along with the STAR reference. Is this a bug, or is it by design?

@pinin4fjords
Copy link
Member

@amizeranschi I believe I have addressed your comment in #1065

The idea in the OP is good but probably not happening for the next release- bumping to the subsequent.

@pinin4fjords pinin4fjords modified the milestones: 3.15.0, 3.16.0 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants