Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a filtering step to handle unplaced chromosomal sequences. V2 #114

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

Shaun-Regenbaum
Copy link

This change fixes #112 among some other issues I saw people talking about in the slack for the past year or two.
Primarily it handles cases where before the exome.bed and genome.dict file had mismatches.

This should make the pipeline more resilient especially while using less common reference genomes (such as cow).

I ran the tests and they passed, not sure if we would want to include this in the changelog as its pretty minor.

Other that that, this is my first contribution to nf-core so would love feedback. Sorry about the repeat PR #113 , I just pulled the wrong version.

Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @Shaun-Regenbaum,

It looks like this pull-request is has been made against the Shaun-Regenbaum/rnavar_edit master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the Shaun-Regenbaum/rnavar_edit dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@Shaun-Regenbaum Shaun-Regenbaum changed the base branch from master to shaun-patch December 27, 2023 16:18
@maxulysse maxulysse changed the base branch from shaun-patch to dev December 29, 2023 10:52
@maxulysse
Copy link
Member

looks ok to me, just need to be sure that it's working, if I remember well, that was our whole issue there

@maxulysse
Copy link
Member

@Shaun-Regenbaum sorry about that, but I'd reckon we'd need to fix the conflicts

@Shaun-Regenbaum
Copy link
Author

Im going to try update this and get it working

@Shaun-Regenbaum
Copy link
Author

I actually odon;t know about this yet, everything is kind of a mess and doesn't work properly with nf-core tools right now, so I don't even know where there are conflicts, I am going to abandon this again for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure on GATK4_BEDTOINTERVALLIST due to incorrect exome.bed generation from iGenomes References.
2 participants