Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to turn read QC on/off #324

Closed
vinisalazar opened this issue Jul 14, 2023 · 2 comments · Fixed by #325
Closed

Add functionality to turn read QC on/off #324

vinisalazar opened this issue Jul 14, 2023 · 2 comments · Fixed by #325
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@vinisalazar
Copy link

Description of feature

Hi,

Thank you for providing taxprofiler. It is a fantastic tool.

Sometimes I run the workflow and I don't want to have to run the FastQC/Falco step, either because I have already ran it before and am unable to get the -resume mechanism to pick it up, or I simply don't need it.

Would it be possible to add the functionality to turn it on/off, like with the adapter trimming step?

I have managed to deactivate it locally on my copy of the workflow. Would you welcome a PR attempting to add this functionality?

Thank you for any assistance you can provide.

Best,
Vini

@vinisalazar vinisalazar added the enhancement Improvement for existing functionality label Jul 14, 2023
@jfy133
Copy link
Member

jfy133 commented Jul 14, 2023

Your wish is my command ☝️!

@jfy133 jfy133 added this to the 1.1.0 - Augmented Akita milestone Jul 14, 2023
@jfy133 jfy133 self-assigned this Jul 14, 2023
@jfy133 jfy133 linked a pull request Jul 17, 2023 that will close this issue
9 tasks
@jfy133 jfy133 closed this as completed Jul 17, 2023
@vinisalazar
Copy link
Author

Thank you so much @jfy133 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants