Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and enhancements for nf annotation utils #183

Open
anngvu opened this issue Jul 25, 2024 · 0 comments · May be fixed by #186
Open

Fixes and enhancements for nf annotation utils #183

anngvu opened this issue Jul 25, 2024 · 0 comments · May be fixed by #186
Assignees
Labels
bug Something isn't working

Comments

@anngvu
Copy link
Contributor

anngvu commented Jul 25, 2024

Some more fixes an enhancements to note:

  • It seems it is possible for samtools to not have a row for an outputted bam, so should use a left join when merging data so a bam file is not missing in the generated manifest.
  • The API/approach CNVkit for annotate_cnv is actually pretty different than from annotate_called_variants or annotate_expression when it doesn't have to be, mostly bc it was written a year after the first two. But anyone trying to use annotate_cnv with one of the other two at the same time will likely be a little thrown off by the different implementations. Ergo, this should be rewritten to resolve inconsistencies.
  • Do more automatic detection/extraction of workflow meta instead of users having to input certain ids or labels.
  • Ensure pipe-able expressions.

This is clustered with #182, #178, #55 and can take into account one or more of those issues so the refactor synergizes resolution with these other issues / makes it easier to resolve these other issues. Alongside the work on other issues, this should yield and overall faster, more thorough, more intuitive, and more consistent set of annotation utilities.

@anngvu anngvu added the bug Something isn't working label Jul 25, 2024
@anngvu anngvu self-assigned this Jul 25, 2024
@anngvu anngvu linked a pull request Aug 15, 2024 that will close this issue
@anngvu anngvu linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant