New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Wrong Comment types in RO-Crate export of LabProcess and Publication. #400

Open

floWetzels opened this issue Jul 5, 2024 · 1 comment

Labels

Status: Needs Triage

Collaborator

floWetzels commented Jul 5, 2024 •

edited

Loading

In the RO-Crate export, comments attached to ISA types should either be mapped to

the field comment of type Comment, if the ISA type maps to a schema.org type inheriting from CreativeWork, or
to the field disambiguatingDescription of type Text, if the ISA type maps to a schema.org type not inheriting from CreativeWork.

Two types contradict this convention: Publication and Process.

Publication is mapped to ScholarlyArticle which has a comment field, but the current export uses the encoder to disambiguatingDescription, as does the corresponding context file.
Process is mapped to LabProcess which doesn't have a comment field, but the current export uses the encoder to Comment, contradicting its context file.

The text was updated successfully, but these errors were encountered:

github-actions bot added the Status: Needs Triage label

Member

HLWeil commented Jul 8, 2024

Good catch!

Could you annotate this issue in the ARCStack project, assign yourself if you're going to work on it and remote the Status: Needs Triage tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment