Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Unify ARC api #419

Open
Freymaurer opened this issue Jul 18, 2024 · 4 comments
Open

[Feature Request] Unify ARC api #419

Freymaurer opened this issue Jul 18, 2024 · 4 comments
Assignees

Comments

@Freymaurer
Copy link
Collaborator

For the upcoming ARCtrl 2.0.0 release we want to add some more breaking changes to unify our top level api!

In this specific case we want to adapt the contract functions to apply to CRUD syntax.

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Jul 18, 2024
@kMutagene kMutagene self-assigned this Jul 18, 2024
@kMutagene kMutagene removed the Status: Needs Triage This item is up for investigation. label Jul 18, 2024
@HLWeil
Copy link
Member

HLWeil commented Jul 29, 2024

Hey @Freymaurer, are you talking about the helper functions directly manipulating contracts or the methods called on ARCs?

@Freymaurer
Copy link
Collaborator Author

I am talking about remove/delete. As we have delete contracts but operations on ARC are called "remove"

@HLWeil
Copy link
Member

HLWeil commented Jul 29, 2024

I see, this actually stems from ARCCommander naming. where we had:

  • Delete = Remove Files
  • Unregister = Remove Registration
  • Remove = Remove Files and Registration

But I guess as we don't have these three options in the ARCtrl API anyway it doesn't matter.

@kMutagene
Copy link
Member

@HLWeil seems like 2.0 was released without this inclusion, so ill put this into the backlog for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants