Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pasting value into unit cell overrides unit #506

Open
micwij opened this issue Aug 13, 2024 · 4 comments
Open

[Bug]: Pasting value into unit cell overrides unit #506

micwij opened this issue Aug 13, 2024 · 4 comments
Assignees
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@micwij
Copy link

micwij commented Aug 13, 2024

Contact Details

[email protected]

What happened?

When pasting a value (Ctrl + V) into a cell that has a unit the unit disappears. In the hidden cells the unit column now has a "-". With right click and selecting "as Unit cell" the value gets transferred to the hidden Unit column instead of restoring the original unit.

When typing in the value the unit persists, however there are two other things that I noticed here:

  1. The first keystroke per cell does not fill in any value.
  2. The hidden Unit column takes on the whole value e.g. "1 Liter" instead of retaining just the unit e.g. "Liter".

What did you expect?

I would expect the unit to persist independent of whether it is typed in individually or pasted in with Ctrl + V.
Having individual cells without a unit or a different unit then other cells of the same column may be desirable in specific cases but under default conditions, I would expect cells in the same column to have the same unit.

Host

Standalone

Host Details

Same behavior in Swate plug-in in
Arcitect version: 0.0.40

Swate version

v1.0.0-beta.07

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Aug 13, 2024
@Freymaurer
Copy link
Collaborator

Hello, thank you for the feedback! What exactly is the "value" you are trying to paste?

@Freymaurer Freymaurer added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Aug 13, 2024
@micwij
Copy link
Author

micwij commented Aug 13, 2024

I was only trying with numbers before e.g. "5" or "44.2" but I just tested it with a text and it looks like it has the same effect, although cells with a unit most likely would not have text in them.

@Freymaurer Freymaurer self-assigned this Sep 9, 2024
@Freymaurer
Copy link
Collaborator

Sorry for not answering for quite some time! I was on a longer time away and this message got lost in the douzens of emails i got.

Okay i think i understand the issue. You copy one value such as "5", "44.2" or "text placeholder" and paste it into a unit cell.

The current implementation fits the pasted value in the full unit block. Which means value, unit name, unit tsr and unit tan. As you only paste one value it assumes empty for the others. This is a rather complex issue which is not easily fixable.

Is a new context menu option a possible solution? Something along the lines "Paste Update"?

@micwij
Copy link
Author

micwij commented Sep 23, 2024

Sorry for the delay on my end now.

I see. Yes, I suppose that might be a good solution. Also if possible to have the "Update"-function separately, could also be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: In discussion
Development

No branches or pull requests

2 participants