[data issue] import_ids() players missing gsis_id, but appear in import_weekly_data() with a player_id

[LarryLoveIV]

Is there an existing issue for this?

• I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

• I have installed the latest development version of the package.

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

0.3.3

Describe the bug

The following players appear in weekly data with a player_id, but no gsis_id in import_ids():

['Taylor Decker',
'Trenton Scott',
'Mike Caliendo',
'Tyler Smith',
'Vederian Lowe',
'Tanner Conner',
'Tyreik McAllister',
'Juanyeh Thomas',
'Aaron Shampklin',
'Tucker Fisk',
'Ben VanSumeren',
'Grant DuBose',
'Christopher Brooks',
'Blake Whiteheart',
'Ryan Miller',
'Brycen Tremayne',
'John Samuel Shenker',
'Wanya Morris',
'Jermaine Jackson',
'Cam Grandy',
'Bryce Oliver',
'Terrell Jennings']

This makes it difficult to join to other data sources in the package (pfr,ftn,etc.).

Reprex

import pandas as pd
import numpy as np
import nfl_data_py as nfl

weekly_df = nfl.import_weekly_data([2024])
id_df = nfl.import_ids()
weekly_df = pd.merge(weekly_df, id_df[['gsis_id', 'pfr_id']], left_on='player_id', right_on='gsis_id', how='left', indicator=True)
[i for i in weekly_df[weekly_df['_merge']=='left_only']['player_display_name'].unique()]

Expected Behavior

Would expect a query on 'left_only' to return no results.

nflverse_sitrep

NA

Screenshots

No response

Additional context

No response

[mrcaseb]

This is actually an issue about missing gsis_id <-> pfr_id mappings of some players.

Some notes on this:

1. Whenever you are missing an ID of a player, you can open an issue and provide us data. See https://github.com/nflverse/nflverse-players/blob/master/.github/CONTRIBUTING.md
2. Currently, import_ids() relies on player data from https://github.com/dynastyprocess/data/raw/master/files/db_playerids.rds which is mostly fine. However, I have implemented a new players data pipeline and we will replace old players data with the new data in the upcoming offseason.
3. @alecglen this means that you probably need to update some download urls.