From 3f3fbb53eea0a939d6b797e7cd966dbf5db1c5a1 Mon Sep 17 00:00:00 2001 From: Tan-DESKPC Date: Mon, 15 Nov 2021 07:02:30 -0500 Subject: [PATCH 1/3] ensure unique cuts by adding 1 to last cut, fixes #66 --- NEWS.md | 1 + R/sitrep.R | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 633b9a0e..33e36033 100644 --- a/NEWS.md +++ b/NEWS.md @@ -3,6 +3,7 @@ ## New Functions - `nflverse_sitrep()` and `ffverse_sitrep()` give a minimal overview of the package dependencies (v1.1.1.01) +- `_sitrep()` fns receive a small print-related bugfix (v1.1.1.02) --- diff --git a/R/sitrep.R b/R/sitrep.R index 84dfd07c..4f91d275 100644 --- a/R/sitrep.R +++ b/R/sitrep.R @@ -120,7 +120,7 @@ cat_packages <- function(packages,versions){ l <- length(packages) breaks <- cut(x = seq_along(packages), - breaks = c(0, ceiling(l / 3), 2 * ceiling(l / 3), l)) + breaks = c(0, ceiling(l / 3), 2 * ceiling(l / 3), l+1)) p <- split(packages, breaks) v <- split(versions, breaks) From f5b8c5ad41ea673558013c886fb74b4e3a5b65f9 Mon Sep 17 00:00:00 2001 From: Tan Ho <38083823+tanho63@users.noreply.github.com> Date: Mon, 15 Nov 2021 07:18:42 -0500 Subject: [PATCH 2/3] bump minimum R version to 3.6.0 --- .github/workflows/R-CMD-check.yaml | 1 - DESCRIPTION | 2 +- NEWS.md | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml index 24b06f98..2e08ea6f 100644 --- a/.github/workflows/R-CMD-check.yaml +++ b/.github/workflows/R-CMD-check.yaml @@ -32,7 +32,6 @@ jobs: - {os: ubuntu-20.04, r: 'devel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest"} - {os: ubuntu-18.04, r: 'oldrel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/bionic/latest"} - {os: ubuntu-18.04, r: '3.6', rspm: "https://packagemanager.rstudio.com/cran/__linux__/bionic/latest"} - - {os: ubuntu-18.04, r: '3.5', rspm: "https://packagemanager.rstudio.com/cran/__linux__/bionic/latest"} env: R_REMOTES_NO_ERRORS_FROM_WARNINGS: true diff --git a/DESCRIPTION b/DESCRIPTION index 79b569cf..b3cfad00 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -16,7 +16,7 @@ License: MIT + file LICENSE URL: https://nflreadr.nflverse.com, https://github.com/nflverse/nflreadr BugReports: https://github.com/nflverse/nflreadr/issues Depends: - R (>= 3.5.0) + R (>= 3.6.0) Imports: cachem (>= 1.0.0), cli (>= 3.0.0), diff --git a/NEWS.md b/NEWS.md index 33e36033..1383573d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -3,6 +3,7 @@ ## New Functions - `nflverse_sitrep()` and `ffverse_sitrep()` give a minimal overview of the package dependencies (v1.1.1.01) +- Minimum R version bumped to R 3.6.0 - this is the minimum version required to read the [current RDS file-version](https://stat.ethz.ch/R-manual/R-devel/library/base/html/readRDS.html). - `_sitrep()` fns receive a small print-related bugfix (v1.1.1.02) --- From 6df2217387b43c913b7c2d2ea20d2c77aae8f854 Mon Sep 17 00:00:00 2001 From: Tan-DESKPC Date: Mon, 15 Nov 2021 07:36:45 -0500 Subject: [PATCH 3/3] bumpver --- DESCRIPTION | 2 +- NEWS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index b3cfad00..1bb53c1f 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: nflreadr Title: Download 'nflverse' Data -Version: 1.1.1.02 +Version: 1.1.1.03 Authors@R: c( person("Tan", "Ho", , "tan@tanho.ca", role = c("aut", "cre", "cph"), comment = c(ORCID = "0000-0001-8388-5155")), diff --git a/NEWS.md b/NEWS.md index 1383573d..c972f998 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,7 +4,7 @@ - `nflverse_sitrep()` and `ffverse_sitrep()` give a minimal overview of the package dependencies (v1.1.1.01) - Minimum R version bumped to R 3.6.0 - this is the minimum version required to read the [current RDS file-version](https://stat.ethz.ch/R-manual/R-devel/library/base/html/readRDS.html). -- `_sitrep()` fns receive a small print-related bugfix (v1.1.1.02) +- `_sitrep()` fns receive a small print-related bugfix (v1.1.1.03) ---