Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sonarcloud fixes #479

Merged
merged 22 commits into from
Oct 24, 2023
Merged

chore: sonarcloud fixes #479

merged 22 commits into from
Oct 24, 2023

Conversation

nfrechette
Copy link
Owner

No description provided.

@nfrechette nfrechette added this to the v2.1 milestone Oct 21, 2023
@commit-lint
Copy link

commit-lint bot commented Oct 21, 2023

Chore

  • ci: update sonarcloud image to latest (3d8fd2a)
  • update to latest sjson-cpp develop (bbdc933)
  • update to latest rtm develop (8029677)

Bug Fixes

  • ci: remove deprecated sonarcloud property usage (1ba98cc)
  • mark assert functions as noreturn (8dee09a)
  • compression: make variable const when it doesn't change (6c0bab9)
  • compression: properly handle track array looping policy when moving (e194262)
  • core: use default initializer (6484e90)
  • core: use RTM macros for cpp version & compiler detection (a079194)
  • use bit_cast instead of reinterpret_cast for safety (b63196d)
  • core: force integral type to be same width as pointer before bit_cast (78a343c)
  • core: let template argument auto-deduce to avoid type safety issue (499983c)
  • compression: add missing const keyword (829f11f)

Styles

  • don't explicitly call constructors (68dc9aa)
  • cleanup whitespace (d3c0df4)
  • core: remove redundant parenthesis (abc6feb)
  • compression: use default initializer (34fbe18)
  • decompression: fix whitespace (c035b73)
  • compression: use explicit default initializer (99a15b2)
  • compression: use explicit default initializer (3edfcf3)
  • core: add function comment and clean up template argument names (090af1c)

Features

  • introduce a bit_cast shim (25abd8e)

Contributors

nfrechette

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@nfrechette nfrechette force-pushed the chore/sonarcloud-fixes branch from 62566a3 to 99a15b2 Compare October 22, 2023 14:59
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
8.9% 8.9% Duplication

@nfrechette nfrechette merged commit c31a602 into develop Oct 24, 2023
133 checks passed
@nfrechette nfrechette deleted the chore/sonarcloud-fixes branch October 24, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant