Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question/documentation of stability guarantees of NGINX_VERSION environment variable #929

Open
rlee287 opened this issue Sep 9, 2024 · 2 comments

Comments

@rlee287
Copy link

rlee287 commented Sep 9, 2024

The Dockerfiles used to build the Nginx images use the environment variable NGINX_VERSION to internally specify the NGINX version to download or build. Is this an implementation detail, subject to change arbitrarily without notice, or can this be considered part of the stable interface the container provides (that can be reliably used to e.g. query the NGINX version in an a custom /docker-entrypoint.d script)? If this is part of the stable interface, I believe this should be documented somewhere.

@oxpa
Copy link
Collaborator

oxpa commented Sep 9, 2024

you can rely on NGINX_VERSION to be present in the image. Dockerfiles are created per nginx version so it's easy and helpful to have this variable.
We'll work on documenting env variables

@thresheek
Copy link
Collaborator

I think it can be considered a stable interface, yes. We rely on it in multiple parts of official Dockerfiles, and in modules/ too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants