Skip to content

fix: standardise test comments #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: standardise test comments #15

merged 1 commit into from
Jul 9, 2025

Conversation

oseoin
Copy link
Collaborator

@oseoin oseoin commented Jul 8, 2025

Proposed changes

Update and add test docstrings

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin marked this pull request as ready for review July 8, 2025 15:27
@oseoin oseoin requested a review from a team as a code owner July 8, 2025 15:27
@agazeley
Copy link

agazeley commented Jul 8, 2025

nit: line lengths are pretty long for python3 code but that is probably the whole codebase not just the docstrings.

@oseoin oseoin merged commit 4b82bf1 into main Jul 9, 2025
11 checks passed
@oseoin oseoin deleted the oseoin/test_description_normalisation branch July 9, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agazeley agazeley agazeley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oseoin @agazeley