The Dockerfile.latest-njs file contains an incorrect URL in the FROM statement

[UncleIgor]

The Dockerfile.latest-njs file contains an incorrect URL in the FROM statement.

Dockerfile.latest-njs:4 | >>> FROM nginx-s3-gateway

ERROR: failed to solve: nginx-s3-gateway: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

To Reproduce

1. git clone https://github.com/nginxinc/nginx-s3-gateway.git
2. cd nginx-s3-gateway
3. docker build -t build_x -f Dockerfile.latest-njs .

Environment

commit 231fa7d (HEAD -> master, origin/master, origin/HEAD)

Additional context

The issue can be resolved by updating the URL in the FROM block from nginx-s3-gateway to nginxinc/nginx-s3-gateway.

[4141done]

Hello, thank you for pointing out this issue. This is actually a side effect of the fact that the test suite is coupled with the build process but you're correct that it's confusing.

Right now, I'm working on refactoring the integration test suite to be a little more manageable which will include:

• Producing arm64 builds of all the images (addressing Arm64 build #196)
• Separating the build and test actions while maintaining integration tests run against the artifacts to be published

The latest-njs assumes that you've locally built the mainline image. See here:

nginx-s3-gateway/test.sh

Line 320 in 231fa7d

p "Layering in latest NJS build"

So in addition to your stated workaround of supplying the full path to the hosted image, you can also first built that image locally under that name as our build step currently does:

docker build -f Dockerfile.oss \
      --tag nginx-s3-gateway --tag nginx-s3-gateway:oss.
      
 docker build -f Dockerfile.latest-njs \
    --tag nginx-s3-gateway:latest-njs-oss.

So you should see some changes soon to address this confusing aspect. I appreciate you taking the time to give this feedback.