Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong use of "altitude" for elevation #10

Closed
NoRi2909 opened this issue Nov 16, 2024 · 1 comment
Closed

[Bug] Wrong use of "altitude" for elevation #10

NoRi2909 opened this issue Nov 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@NoRi2909
Copy link
Contributor

Short summary 📝

The entity Moon altitude should be named Moon elevation

Detailed description 📋

The entity "Moon altitude" uses the wrong term. This is the angle above or below the horizon which is called "elevation".
Similar to the azimuth as the angle from the north.

An altitude would be a distance measured in meters or kilometers which you already provide in "Moon distance".

I see that many sources also use the wrong term but you should stick to "elevation" which is mathematically correct.

Version 📌

0.2

Environment 🌐

No response

Logs and screenshots 📂

No response

@NoRi2909 NoRi2909 added the bug Something isn't working label Nov 16, 2024
@NoRi2909
Copy link
Contributor Author

@ngocjohn Similar fix necessary for "Moon highest" which should be "Culmination" instead. The German translation already uses "Kulmination" so it's not visible here.

https://en.wikipedia.org/wiki/Culmination

For today you show "Moon highest: 17:39" and as you can see in the graphic this is actually the lowest, not the highest point of the moon's path:

image

@ngocjohn ngocjohn closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants