Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom metrics and trace labels provided from the context #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support custom metrics and trace labels provided from the context #291

wants to merge 1 commit into from

Conversation

nhatthm
Copy link
Owner

@nhatthm nhatthm commented Mar 27, 2024

Description

Support custom metrics and trace labels provided from the context

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b373779) to head (32ef0f0).

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #291   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        23    +1     
  Lines         1038      1075   +37     
=========================================
+ Hits          1038      1075   +37
Flag Coverage Δ
unittests-Linux-X64 100.00% <100.00%> (ø)
unittests-Windows-X64 100.00% <100.00%> (ø)
unittests-macOS-X64 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhatthm nhatthm mentioned this pull request Mar 27, 2024
Open
@nhatthm
Copy link
Owner Author

nhatthm commented Mar 27, 2024

@manishdangi98 could you please confirm if this matches your expectations?

@nhatthm nhatthm linked an issue Mar 27, 2024 that may be closed by this pull request
Adding custom labels to metrics #222
Open
@rajyan
Copy link

rajyan commented May 5, 2024 •
edited
Loading

I think we can already add custom labels from context to "trace" by using "TraceQuery" option.
https://github.com/nhatthm/otelsql?tab=readme-ov-file#trace-query

My idea was to add an option similar for "metrics" too, and I'm currently using this patch to solve my problem.
master...rajyan:otelsql:master

I think this PR doesn't solve this issue described in #222 , because we cannot set labels from the "query".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding custom labels to metrics
2 participants
@nhatthm @rajyan