Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSV sentence not handled correctly when there is only a single satellite present #5

Open
njtromp opened this issue Aug 10, 2015 · 0 comments

Comments

@njtromp
Copy link

njtromp commented Aug 10, 2015

The following sentence (which my Nokia LD-3W Bluetooth GPS dongle emitted today) results in a 'not enough tokens' error in the codes/GSV.js module.

$GPGSV,3,3,09,24,06,148,22*4D

According to this information http://www.gpsinformation.org/dale/nmea.htm#GSV there can be up to four satellites present in a GSV sentence. The above sentence only holds information for a single satellite. Which makes sense given the fact that there are 9 satellites and this is the third GSV sentence.
As far as I can tell the check done on line 9 of codes/GSV.js 'if(tokens.length < 13) {' should check for a minimum of 8 tokens. The current check assumes that there are at least two satellites 4 + 2x4 = 12 (plus a mysterious extra token??) tokens while there can be 4 +1x4 = 8 tokens when there is only one satellite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant