From a129e75c3ac3ce423df110a682a6cae6819cfee1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Delaporte?=
 <12201973+fredericDelaporte@users.noreply.github.com>
Date: Sun, 1 Nov 2020 16:55:49 +0100
Subject: [PATCH] Release 5.3.4 (#2587)

And document a missing breaking change.
Fixes #2578
---
 build-common/NHibernate.props |  2 +-
 releasenotes.txt              | 26 +++++++++++++++++++++++++-
 2 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/build-common/NHibernate.props b/build-common/NHibernate.props
index 62ec177ced1..67c6bbe5362 100644
--- a/build-common/NHibernate.props
+++ b/build-common/NHibernate.props
@@ -5,7 +5,7 @@
     <NhVersion     Condition="'$(NhVersion)' == ''"    >5.3</NhVersion>
     <VersionPatch  Condition="'$(VersionPatch)'  == ''">4</VersionPatch>
     <!-- Clear VersionSuffix for making release and set it to dev for making development builds -->
-    <VersionSuffix Condition="'$(VersionSuffix)' == ''">dev</VersionSuffix>
+    <VersionSuffix Condition="'$(VersionSuffix)' == ''"></VersionSuffix>
 
     <VersionPrefix Condition="'$(VersionPrefix)' == ''">$(NhVersion).$(VersionPatch)</VersionPrefix>
     <VersionSuffix Condition="'$(VersionSuffix)' != '' AND '$(BuildNumber)' != ''">$(VersionSuffix).$(BuildNumber)</VersionSuffix>
diff --git a/releasenotes.txt b/releasenotes.txt
index bfd2a67804c..b5766fbf4bb 100644
--- a/releasenotes.txt
+++ b/releasenotes.txt
@@ -1,4 +1,26 @@
-Build 5.3.3
+Build 5.3.4
+=============================
+
+Release notes - NHibernate - Version 5.3.4
+
+6 issues were resolved in this release.
+
+** Bug
+
+   * #2580 InvalidWithClauseException when join polymorphic entity
+   * #2559 Regression in caching linq query with ThenFetchMany statement.
+   * #2549 ApplyFilter does not work on join statements in LINQ
+   * #2537 Unable to cast "System.Linq.Expressions.UnaryExpression" to "System.Linq.Expressions.LambdaExpression".
+
+** Task
+
+   * #2578 Add missing possible breaking changes for #2365
+   * #2587 Release 5.3.4
+
+As part of releasing 5.3.4, one missing 5.3.0 possible breaking change has been added, about
+custom method generators for Linq. See 5.3.0 possible breaking changes.
+
+Build 5.3.3
 =============================
 
 Release notes - NHibernate - Version 5.3.3
@@ -135,6 +157,8 @@ Release notes - NHibernate - Version 5.3.0
           already exists in the set will now return false.
         * Calling `ISet<>.Add` or `ICollection<>.Add` on an uninitialized set mapped as `lazy="true"` with a
           transient element that does not override `Equals` method will not initialize the collection.
+        * Linq custom generators deriving from `BaseHqlGeneratorForMethod` should override the
+          `TryGetCollectionParameter` method if they have to support parameter lists.
 
 ** Bug