Expanding OnDeleteAction enum by adding SetNull

[radiy]

Hi, what about adding SetNull to

nhibernate-core/src/NHibernate/Mapping/ByCode/IKeyMapper.cs

Line 7 in ac39173

public enum OnDeleteAction

.
Any particular reason for not doing it?

[fredericDelaporte]

It just needs to be actually implemented, starting from hbm through everywhere on-delete action is implemented.

[radiy]

Totally agree. It was a bit of surprise to find it unimplemented.
I was thinking that maybe there some special reasons for this.
What do you think about implementation strategy?
It mapped to bool value

nhibernate-core/src/NHibernate/Mapping/ForeignKey.cs

Line 69 in 58e3cb2

public bool CascadeDeleteEnabled

and changing it to enum will be breaking change, but creating another bool field feels unnatural.
I wonder what would be better, creating new boolean field bool CascadeSetNullEnabled or creating new enum field DeleteAction CascadDeleteAction and obsoleting CascadeDeleteEnabled.

[fredericDelaporte]

creating new enum field DeleteAction CascadDeleteAction and obsoleting CascadeDeleteEnabled

I would go for this, with CascadeDeleteEnabled just yielding its value according to CascadDeleteAction value and setting CascadDeleteAction on set.