Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags is changed when deleting heading contents #493

Closed
seong954t opened this issue May 15, 2019 · 4 comments
Closed

tags is changed when deleting heading contents #493

seong954t opened this issue May 15, 2019 · 4 comments

Comments

@seong954t
Copy link

seong954t commented May 15, 2019

Version

tui-editor version 1.4.0

Test Environment

Windows 10, Chrome Browser

Current Behavior

There seems to be a problem using the heading of the tui editor.
현재 tui editor의 Heading을 사용하는데 문제가 있는것 같습니다.

1. When heading is first created, the tag is generated as shown below. (처음 Heading을 만들면 아래와 같이 태그가 생성됩니다.)

<h1>
    <div>
        <br>
    </div>
</h1>

screen_1

2. At this time, if you write inside the heading, the results are as follows: (이 때 Heading내부에 글을 작성하게되면, 아래와 같은 결과가 나오게 됩니다.)

<h1>
    <div>가나다라</div>
</h1>

screen_2

3. However, if you erase the created text one by one with Backspace, the tag is generated as shown below. (그러나 작성된 글을 하나씩 Backspace로 지우게 되면 아래와 같이 태그가 생성됩니다.)

<h1>
    <br>
</h1>

screen_3

4. So if you write the contents in heading in that state, the tag will be created in the following form which is different from the one when you write an existing article (write the letters in the div tag). (그래서 해당 상태에서 Heading에 내용을 작성하게 되면 기존의 글을 작성할 때(div태그 내 글자가 작성)와 다른 아래와 같은 형태로 태그가 생성됩니다.)

<h1>가나다라2</h1>

screen_4

Expected Behavior

If all the characters are deleted in the tag, I expect the following results. (해당 태그 내에서 글자를 모두 지웠을 경우에도 아래와 같은 결과가 나오길 기대합니다.)

<h1>
    <div>
        <br>
    </div>
</h1>

However, the actual behavior results in the following:

<h1>
    <br>
</h1>

In this case, the non-regular tags cause problems with the desired behavior and leave an issue. Please check and answer my opinion.
이러한 경우 규칙적이지 않은 태그들로 인해 원하고자 하는 동작에 문제가 발생하여 이슈를 남깁니다. 확인해주시고 저의 의견에 대한 답변 부탁드립니다.

@sohee-lee7 sohee-lee7 changed the title Heading 내용 삭제 시 태그 변형 이슈가 있는 것 같습니다. tags is changed when deleting heading contents May 16, 2019
@sohee-lee7
Copy link
Contributor

이슈 관리 정책 상 이슈 제목과 본문을 영어로 번역하였습니다. 양해 부탁드립니다. 해당 이슈는 확인하였고, 분석 후 답변 드리겠습니다.

@seong954t
Copy link
Author

tui에서 사용하는 Squire에서도 이와 유사한? 이슈가 있어서 등록을 해두었습니다.

해당 이슈는
태그가 적절히 생성되지 않아 줄바꿈을 인식하는데 어려움이 있는 것입니다.
해당 이슈도 링크로 남겨두겠습니다.

fastmail/Squire#353

감사합니다.

@stale
Copy link

stale bot commented Dec 21, 2019

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Dec 21, 2019
@stale
Copy link

stale bot commented Dec 28, 2019

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this as completed Dec 28, 2019
seonim-ryu pushed a commit that referenced this issue Jan 2, 2020
* change condition statement priority
* add condition for non collapsed range check
* change condition for multi TD paste & add removeTableContents()
* change isInTable() to public & extract pasting branch logic from WwPasteContentHelper
* modify condition for table removal
* solve TD paste & wrap TDs into TR and TRs into TBODY
* extract _completeIncompleteTable() method related
* refactor: _getTableDataFromTable
* change table completion stage
seonim-ryu pushed a commit that referenced this issue Jan 6, 2020
* change condition statement priority
* add condition for non collapsed range check
* change condition for multi TD paste & add removeTableContents()
* change isInTable() to public & extract pasting branch logic from WwPasteContentHelper
* modify condition for table removal
* solve TD paste & wrap TDs into TR and TRs into TBODY
* extract _completeIncompleteTable() method related
* refactor: _getTableDataFromTable
* change table completion stage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants