Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add X-Hasura-Role in CORS headers #119

Closed
sradigan opened this issue Oct 24, 2022 · 1 comment · Fixed by #120
Closed

Add X-Hasura-Role in CORS headers #119

sradigan opened this issue Oct 24, 2022 · 1 comment · Fixed by #120

Comments

@sradigan
Copy link
Contributor

Please add X-Hasura-Role to the list of allowed CORS headers.

We are working around this problem by placing the service used for file upload and hasura-storage behind an nginx reverse proxy.

I searched for similar issues, but It looks like most other examples of usage either set the x-hasura-admin-secret, or set the x-hasura-default-role to the desired role. Our usage of hasura is to get a JWT with a list of roles and a default set, then select the role by setting the X-Hasura-Role in the request headers.

@dbarrosop
Copy link
Member

Sounds good, if you want to open a PR yourself that'd be appreciated, otherwise, I will try to get to it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants