Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add already approved icons to NHS App Design System Figma file #142

Open
katydlmh opened this issue Sep 4, 2024 · 5 comments · May be fixed by #169
Open

Add already approved icons to NHS App Design System Figma file #142

katydlmh opened this issue Sep 4, 2024 · 5 comments · May be fixed by #169
Assignees
Labels
component Add or improve a design component feature request figma Issue is associated with the NHS App design system Figma file

Comments

@katydlmh
Copy link

katydlmh commented Sep 4, 2024

Description

Wayfinder will soon be surfacing inpatient appointments within the NHS App. The design of these appointment cards includes three icons, which have been discussed and agreed with the design system team. These icons are not currently part of the NHS App Design System Figma file.

Context

Adding these three icons to the NHS App Design System Figma file will ensure the quality and consistency of their build from third party suppliers building Wayfinder. It will mean that suppliers building these screens can access all icons used in Wayfinder from the same trusted source.

Alternatives

If not added, it would be good to have the icons / appointment cards where they are included built in HTML as part of the app redesign work page, as other bespoke Wayfinder components have been, to ensure quality and consistency across third party suppliers. However, all other icons are currently available to suppliers via the design system file, so this would mean two sources for getting icons.

Additional information (if applicable)

In user research for inpatient design, we found that there was extra information patients needed to understand compared to outpatient appointments, such as the appointment being an overnight stay or a long stay, or an action for patients to phone their clinic. Our research found that adding icons to these pieces of information raised the visual hierarchy of the elements, helping patients to process this information and distinguish them from other appointments.

@nhsuk nhsuk deleted a comment Sep 4, 2024
@davidhunter08 davidhunter08 changed the title [Icon request]: Add already approved icons to NHS App Design System Figma file Add already approved icons to NHS App Design System Figma file Sep 5, 2024
@davidhunter08 davidhunter08 added component Add or improve a design component feature request and removed awaiting triage labels Sep 5, 2024
@davidhunter08
Copy link
Collaborator

The 3 icons:
image

@davidhunter08
Copy link
Collaborator

davidhunter08 commented Sep 5, 2024

Open question: Should all icons we create in Figma match what we have in the NHS App Frontend?

Examples

Icons we have in Figma but not the NHS App Frontend.

Screenshot 2024-09-05 at 11 18 50 Screenshot 2024-09-05 at 11 18 26

@davidhunter08
Copy link
Collaborator

If we decide not to add them to the NHS App Frontend, we could host a HTML (SVG) version of them in the HTML prototype.

@katydlmh
Copy link
Author

katydlmh commented Sep 5, 2024

@davidhunter08 HTML SVG version would work well, but it would be good to build the download, letter and email icons (image above) in the same way too so suppliers had one place to find all the icons they need for Wayfinder (these three are currently accessed via Figma file only)

@davidhunter08 davidhunter08 added the figma Issue is associated with the NHS App design system Figma file label Sep 12, 2024
@davidhunter08 davidhunter08 linked a pull request Oct 16, 2024 that will close this issue
@davidhunter08
Copy link
Collaborator

@katydlmh I'm in the process of adding new icons but I can't find the SVGs for the 3 icons used for overnight stay, call to confirm and long stay. Do you know where I can find them?

@nhsuk nhsuk deleted a comment from katydlmh Oct 17, 2024
@davidhunter08 davidhunter08 self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Add or improve a design component feature request figma Issue is associated with the NHS App design system Figma file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants