Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card links: chevron not aligned with divider line #171

Open
davidhunter08 opened this issue Oct 17, 2024 · 2 comments
Open

Card links: chevron not aligned with divider line #171

davidhunter08 opened this issue Oct 17, 2024 · 2 comments
Labels
component Add or improve a design component visual design

Comments

@davidhunter08
Copy link
Collaborator

davidhunter08 commented Oct 17, 2024

Description

The card link chevron does not align with the divider line.

image

This is the original design spec in Figma (not aligned):

image

@davidhunter08
Copy link
Collaborator Author

davidhunter08 commented Oct 17, 2024

#10 (comment)

we use a simple chevron with no background, but the basic card in the NHS design system has a blue background circle

i suspect using the blue background circle would be far too heavy for the amount of them that we’d have, but if we sort-of-invert them, with a light grey circle BG and a blue chevron, we’d add a bit of visual detailing and be kind of close to the main NHS DS?

Screenshot 2024-10-17 at 09 13 47

@davidhunter08 davidhunter08 changed the title Card link chevron not aligned with divider line Card links: chevron not aligned with divider line Oct 17, 2024
@davidhunter08 davidhunter08 added component Add or improve a design component visual design and removed awaiting triage labels Oct 17, 2024
@imnatgreen
Copy link

I think it's worth noting that the chevron is aligned 'correctly' when including its bounding box.
Screenshot 2024-10-17 at 15 32 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Add or improve a design component visual design
Projects
None yet
Development

No branches or pull requests

2 participants