diff --git a/CHANGELOG.md b/CHANGELOG.md index 14a543291..ceafebac2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ :wrench: **Fixes** +- Fix appearance of the select element for more consistency between browsers and OS ([Issue 527](https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/527)) - Fix appearance of disabled warning buttons ([Issue 1034]([https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/1034])) - Fix reverse button text colour ([PR 1080]([https://github.com/nhsuk/nhsuk-frontend/pull/1080])) - Fix details component requiring html param in uppercase ([PR 1090](https://github.com/nhsuk/nhsuk-frontend/pull/1090), [Issue 1089](https://github.com/nhsuk/nhsuk-frontend/issues/1089)) diff --git a/packages/components/select/_select.scss b/packages/components/select/_select.scss index 1e8411904..5e2f714a9 100644 --- a/packages/components/select/_select.scss +++ b/packages/components/select/_select.scss @@ -14,8 +14,10 @@ .nhsuk-select { @include nhsuk-font(19); + background-color: $color_nhsuk-white; border: $nhsuk-border-width-form-element solid $nhsuk-form-border-color; box-sizing: border-box; + color: $color-nhsuk-black; height: 2.5rem; /* [1] */ min-width: 20ex + 3ex; /* [2] */ max-width: 100%; diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_0_iPhone_5_SE.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_0_iPhone_5_SE.png index 5ed3e2ae7..b2289fe2e 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_0_iPhone_5_SE.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_0_iPhone_5_SE.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_1_iPhone_6-8.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_1_iPhone_6-8.png index 20e5fe0e1..f29f2f987 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_1_iPhone_6-8.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_1_iPhone_6-8.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_2_iPad.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_2_iPad.png index df21b95de..bcfb11a50 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_2_iPad.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_2_iPad.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_3_Surface_iPad_Pro.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_3_Surface_iPad_Pro.png index b5f6ed8f0..164d65804 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_3_Surface_iPad_Pro.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_0_document_3_Surface_iPad_Pro.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_0_iPhone_5_SE.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_0_iPhone_5_SE.png index 422e7ed88..370550dfd 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_0_iPhone_5_SE.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_0_iPhone_5_SE.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_1_iPhone_6-8.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_1_iPhone_6-8.png index 2374860d4..180240cf9 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_1_iPhone_6-8.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_1_iPhone_6-8.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_2_iPad.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_2_iPad.png index 3d6b9832a..61c2244aa 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_2_iPad.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_2_iPad.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_3_Surface_iPad_Pro.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_3_Surface_iPad_Pro.png index fbe4e5703..6b84189f1 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_3_Surface_iPad_Pro.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_-_focused_0_document_3_Surface_iPad_Pro.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_0_iPhone_5_SE.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_0_iPhone_5_SE.png index cafadc87a..d13d73a4b 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_0_iPhone_5_SE.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_0_iPhone_5_SE.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_1_iPhone_6-8.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_1_iPhone_6-8.png index 2582e60eb..061cf5547 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_1_iPhone_6-8.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_1_iPhone_6-8.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_2_iPad.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_2_iPad.png index b92cffb8d..7b0416914 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_2_iPad.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_2_iPad.png differ diff --git a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_3_Surface_iPad_Pro.png b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_3_Surface_iPad_Pro.png index 0eb2fd89d..e0dfefb3b 100644 Binary files a/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_3_Surface_iPad_Pro.png and b/tests/backstop/bitmaps_reference/nhsuk-frontend_Select_with_hint_text_and_error_message_0_document_3_Surface_iPad_Pro.png differ