-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.nhsuk-width-container-fluid class is no longer working as expected. #910
Comments
Hi Femi, thanks for submitting this issue, what browser dimensions are you seeing this sizing issue on? |
The header doesn't cater for this currently at all - it's currently hardcoded to a set width in the We could also consider removing the hardcoded width from the header's styles completely, and putting a |
Hi Roshan, Screen dimension: 1920px width 1080p I just checked again to see if it was a fluke but it is not. I downgraded and upgraded again and the behaviour was replicated. Andy's observation is right, the new styles in the nhsuk-header__container are the culprit. |
Bug Report
What is the issue?
The .nhsuk-width-container-fluid class is no longer working as expected.
I use the class for creating a full screen layout (as opposed to the standard narrower layout).
After upgrading from 7.0.0 to 8.0.2, The fluid full screen layout is applied to the body but not the header, which retains the width of .nhsuk-header__container.
I don't know if it's a bug but it seems like one.
What steps are required to reproduce the issue?
What was the environment where this issue occurred?
The text was updated successfully, but these errors were encountered: