Skip to content

Chromatic Menu matrix test has unexpected Firefox diff #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
m-akinc opened this issue Feb 23, 2024 · 3 comments
Open

Chromatic Menu matrix test has unexpected Firefox diff #1862

m-akinc opened this issue Feb 23, 2024 · 3 comments
Labels
tech debt

Comments

@m-akinc
Copy link
Contributor

m-akinc commented Feb 23, 2024

🧹 Tech Debt

After the recent Chromatic Capture Cloud update, the Menu matrix test has been showing unexpected gaps between some menus and their submenus:
https://www.chromatic.com/test?appId=60e89457a987cf003efc0a5b&id=65d7e05b8ca63d78ed7c6906
image
I cannot reproduce this in my local Firefox (version 123, as opposed to Chromatic's version 121).
Notably, the menus at the top of each theme section do not have the problem. This feels vaguely similar to the issues we had with the Tooltip matrix story.
@m-akinc m-akinc added tech debt triage New issue that needs to be reviewed labels Feb 23, 2024
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Feb 27, 2024
@jattasNI
Copy link
Contributor

I saw this again in this build. It does not reproduce for me in macOS Firefox in the corresponding Storybook.

@jattasNI
Copy link
Contributor

Another instance

@jattasNI jattasNI mentioned this issue Mar 27, 2024
Merged
1 task
@jattasNI jattasNI mentioned this issue Jun 12, 2024
Merged
1 task
@jattasNI
Copy link
Contributor

The steps to work around this diff are captured in this comment

This was referenced Mar 17, 2025
Merged
Open
rajsite added a commit that referenced this issue Mar 17, 2025
@rajsite
Rebuild chromatic snapshots on new infrastructure version (#2554)
ee50d53 
# Pull Request

## 🤨 Rationale

Chromatic infrastructure was updated and [new baselines were
auto-accepted](https://www.chromatic.com/docs/infrastructure-upgrades/#upgrade-builds)
but when running a full re-build there are still dirty changes because:
- Chromatic auto accepted the incorrect version of the [unstable
fiirefox menu story](#1862)
- chat message and chat conversation stories were unstable due to
animated spinner usage

## 👩‍💻 Implementation

- Disable the chat stories spinner animations
- Tweak preview.js for a full build
- Accept the changes as new baselines

## 🧪 Testing

Rely on CI

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
Nimble Design System Priorities
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-akinc @jattasNI