Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configurability of the NGX_RESOLVE_ errors to use fallback for #28

Open
nicholaschiasson opened this issue Aug 9, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nicholaschiasson
Copy link
Owner

nicholaschiasson commented Aug 9, 2020

Currently, we have hardcoded the cases of NGX_RESOLVE_FORMERR and NGX_RESOLVE_NXDOMAIN as errors for which we always use the fallback. It would be more interesting to allow the configuration to select which resolve errors should always use the fallback. This could possibly be an enhancement of the strict attribute.

See here for list of errors: http://lxr.nginx.org/source/xref/nginx/src/core/ngx_resolver.h#27

#define NGX_RESOLVE_FORMERR   1
#define NGX_RESOLVE_SERVFAIL  2
#define NGX_RESOLVE_NXDOMAIN  3
#define NGX_RESOLVE_NOTIMP    4
#define NGX_RESOLVE_REFUSED   5
#define NGX_RESOLVE_TIMEDOUT  NGX_ETIMEDOUT
@nicholaschiasson nicholaschiasson added enhancement New feature or request help wanted Extra attention is needed labels Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant