Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of ngx_strcmp #34

Closed
nicholaschiasson opened this issue Aug 12, 2020 · 0 comments · Fixed by #37
Closed

Fix usage of ngx_strcmp #34

nicholaschiasson opened this issue Aug 12, 2020 · 0 comments · Fixed by #37
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nicholaschiasson
Copy link
Owner

Inspired by wdaike/ngx_upstream_jdomain#10.

Contrary to that pull request however, I believe this should only apply to the fixed length switch attributes like retry_off and strict. It's an unnecessary check for the other attributes.
@nicholaschiasson nicholaschiasson added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Aug 12, 2020
@nicholaschiasson nicholaschiasson mentioned this issue Aug 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix usage of ngx_strncmp nicholaschiasson/ngx_upstream_jdomain
1 participant
@nicholaschiasson