Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve least_conn test case #78

Open
nicholaschiasson opened this issue Jun 5, 2022 · 0 comments
Open

Improve least_conn test case #78

nicholaschiasson opened this issue Jun 5, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nicholaschiasson
Copy link
Owner

In t/004.compatibility_nginx.t, test 3 is supposed to use jdomain with the least_conn algorithm, but the test is actually quite weak, making it not obvious to determine is the least_conn algorithm is even properly working.

The test only makes single connections at a time to the test nginx server, resulting in the load balancer effectively using round robin, which is indeed a valid behaviour of least_conn, but not representative of a live scenario where the peer is actually chosen based on least connected peers.

This test case should be improved to simulated many simultaneous connections to the upstream block so we can really see least_conn in action with jdomain upstreams.

@nicholaschiasson nicholaschiasson added enhancement New feature or request help wanted Extra attention is needed labels Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant