Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize values and units on all exporters #116

Open
nickbabcock opened this issue Jan 22, 2020 · 0 comments
Open

Normalize values and units on all exporters #116

nickbabcock opened this issue Jan 22, 2020 · 0 comments

Comments

@nickbabcock
Copy link
Owner

After implementing #67 to conform to prometheus best practices, I'd like to apply that PR to the other exporters. I want:

  • One type to represent number of bytes. SmallData (2^20) and Data (2^30) should just become bytes, so that one doesn't need to lookup source code to figure out how to convert them to bytes.
  • One type to represent frequency (Hz). Frequency (Hz) and Clock (MHz) should be consolidated into hertz. Clock is annoying in grafana as there isn't a native MHz unit, so one has to multiply values by 1000000 before mapping to Hz.
  • All exporters to be consistent in the data they are exporting

I haven't decided yet if the other exporters should adopt the more descriptive names like prometheus (eg: prefer "bytes_per_second" over "Throughput"), so I'm unlikely to act on this issue immediately.

I think any solution will require the use of a config field like normalize_units that will be enabled by default. That way new installations will, by default, use the improved units and values, while ongoing installations can opt into preserving their desired behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant