Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a saved window then closing it clears the state #18

Open
nickbaum opened this issue May 30, 2012 · 2 comments
Open

Opening a saved window then closing it clears the state #18

nickbaum opened this issue May 30, 2012 · 2 comments
Labels

Comments

@nickbaum
Copy link
Owner

If you open a saved window and close it before the tabs are fully loaded, the saved window contains 0 tabs.

@NathanGillis
Copy link

Need to Recheck if the window is closing. Think the chrome.window.get or chrome.tabs.getAllInWindow is asynchronous. So the to modify the window is firing after window has started to close. Added recheck to
eventHandlers

getPopulatedWindow(windowId, function(browserWindow) {
+    if (isWindowClosing[windowId]||istabLoading[tabId]){
+      return;
+    }

@ajayyy
Copy link

ajayyy commented Jun 4, 2017

Still an issue :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants