From 18af88a70b123e68d695cd06e5ffc810eeefd9a7 Mon Sep 17 00:00:00 2001 From: tyf1946 Date: Sat, 15 Jun 2019 17:20:17 +0800 Subject: [PATCH] fix NullPointerException HomeActivity method onPrepareOptionsMenu menu.findItem(R.id.menu_designer_news_login) return null object use onCreateOptionsMenu find menu_designer_news_login --- app/src/main/java/io/plaidapp/ui/HomeActivity.kt | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/io/plaidapp/ui/HomeActivity.kt b/app/src/main/java/io/plaidapp/ui/HomeActivity.kt index b4da3dfa5..f66659e39 100644 --- a/app/src/main/java/io/plaidapp/ui/HomeActivity.kt +++ b/app/src/main/java/io/plaidapp/ui/HomeActivity.kt @@ -100,6 +100,7 @@ class HomeActivity : AppCompatActivity() { private lateinit var loading: ProgressBar private lateinit var feedAdapter: FeedAdapter private lateinit var filtersList: RecyclerView + private lateinit var mDesignerNewsLogin: MenuItem // data @Inject @@ -439,8 +440,7 @@ class HomeActivity : AppCompatActivity() { } override fun onPrepareOptionsMenu(menu: Menu): Boolean { - menu.findItem(R.id.menu_designer_news_login) - .setTitle( + mDesignerNewsLogin.setTitle( if (viewModel.isDesignerNewsUserLoggedIn()) { R.string.designer_news_log_out } else { @@ -450,6 +450,12 @@ class HomeActivity : AppCompatActivity() { return true } + override fun onCreateOptionsMenu(menu: Menu?): Boolean { + menuInflater.inflate(R.menu.main,menu) + mDesignerNewsLogin = menu!!.findItem(R.id.menu_designer_news_login) + return true + } + override fun onOptionsItemSelected(item: MenuItem): Boolean { return when (item.itemId) { R.id.menu_filter -> {