Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Handling of SIGINT/SIGQUIT #85

Open
claymation opened this issue Oct 16, 2014 · 4 comments
Open

Proper Handling of SIGINT/SIGQUIT #85

claymation opened this issue Oct 16, 2014 · 4 comments

Comments

@claymation
Copy link

In researching #70, I ran across Proper Handling of SIGINT/SIGQUIT, which recommends that if a child execed by honcho run exits due to SIGINT, Honcho should kill(SIGINT) itself in order to properly terminate shell scripts that may have invoked Honcho.

It's a fascinating, if long-winded article, but the premise is that the child should determine how to handle SIGINT, and parents (while ignoring SIGINT themselves), should honor the child's decision if it decides to exit by propagating the SIGINT exit status back up the ancestor chain to the shell.

@ghost
Copy link

ghost commented May 26, 2015

Control-C now is not making the server exit as before :(

@chaosmail
Copy link

I realized, that when I kill the honcho start process with ctrl-c, the children keep on running - this is somehow the other way round than this issue. Is there something to prevent this, and kill all spanned processes?
Thanks!

@chaosmail
Copy link

Any updates on this?

@claymation
Copy link
Author

@chaosmail Maybe you're referring to the change in #84. In that change, honcho run will ignore SIGINT, allowing the child to handle that signal as it will. I don't believe that change had any impact on honcho start, however.

This issue (#85) is simply a request for enhancement to follow best practices when a child exits due to SIGINT. It's probably not the issue you're looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants