Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRITICAL errors occur in chain notes composed of elements only (no head notes), and the notes cannot be cut. #167

Open
rynan4818 opened this issue Oct 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rynan4818
Copy link

rynan4818 commented Oct 19, 2024

  • Operating system: Windows 11
  • Headset and controllers: HTC Vive pro
  • BeatSaber 1.29.1 and 1.38.0
  • CustomAvatars 5.3.2 and 5.4.6

Describe the bug
CRITICAL error occurs in the chain notes made up of only elements near 27 seconds in the Lawless Expert+ map below.
https://beatsaver.com/maps/40908
There are other maps with the same problem.

The error occurs in the following line of the source code: InvalidOperationException: Sequence contains no matching element.

https://github.com/nicoco007/BeatSaberCustomAvatars/blob/main/Source/CustomAvatar/Utilities/BeatmapObjectEventFilter.cs#L148

Because the processing that combines the occurrence of Chain Notes events is based on BurstSliderHead, if BurstSliderElement is the first element in the Map, an error will occur because Head cannot be found.

As I couldn't think of a way to fix it properly, I made a simple patch to suppress the CRITICAL error for the time being.

https://github.com/rynan4818/CustomAvatarsGetHeadNotePatch/releases

Also, I think there are many users who are using BS1.29.1, so please also fix it for 5.3.2.

@rynan4818 rynan4818 added the bug Something isn't working label Oct 19, 2024
@nicoco007
Copy link
Owner

Thanks for the report! I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants