Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py - remove insecure requests to https://pypi.org/pypi/python-appimage/json #36

Open
manfred-kaiser opened this issue Jun 28, 2021 · 1 comment
Open

setup.py - remove insecure requests to https://pypi.org/pypi/python-appimage/json #36

manfred-kaiser opened this issue Jun 28, 2021 · 1 comment

Comments

@manfred-kaiser
Copy link
Contributor

the request to https://pypi.org/pypi/python-appimage/json should be removed, because it breaks workflows, when running without an internet connection.

Another reason is, that you are using _create_unverified_context, which disables certificate validation.

This makes using you package insecure and prone to man in the middle attacks.

Determine the version number this way also breaks reproducible builds.
@manfred-kaiser manfred-kaiser mentioned this issue Jun 28, 2021
Closed
@hendursaga
Copy link

Is the security aspect of this resolved yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manfred-kaiser @hendursaga